Validate data messages #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mddub
force-pushed
the
validate-app-messages
branch
from
e5359ef
to
1fcde55
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having different components access the app message directly, this change validates the data app message (in case it's from a client using a format which differs from the Urchin JS) and stores the result in a
DataMessage, which is used instead. This mostly fixes #20.This also paves the way for caching data messages on the watch (so that the last-received data appears immediately on load) and other minor improvements (e.g. making the staleness state of the BG element consistent with the graph, avoiding redraws on unchanged data to save battery).